From ca3f6f33d1b39ff00a068f63728ed2032f99bab7 Mon Sep 17 00:00:00 2001 From: laxmanhalaki Date: Fri, 19 Dec 2025 21:48:02 +0530 Subject: [PATCH] build issue resolved --- src/components/sla/SLAProgressBar/SLAProgressBar.tsx | 5 ++--- src/dealer-claim/components/request-detail/WorkflowTab.tsx | 2 -- .../components/request-detail/modals/CreditNoteSAPModal.tsx | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/components/sla/SLAProgressBar/SLAProgressBar.tsx b/src/components/sla/SLAProgressBar/SLAProgressBar.tsx index 4e394b1..535d7c9 100644 --- a/src/components/sla/SLAProgressBar/SLAProgressBar.tsx +++ b/src/components/sla/SLAProgressBar/SLAProgressBar.tsx @@ -30,7 +30,7 @@ export function SLAProgressBar({ // Pure presentational component - no business logic // If request is closed/approved/rejected or no SLA data, show status message // Check if SLA has required fields (percentageUsed or at least some data) - const hasValidSLA = sla && (sla.percentageUsed !== undefined || sla.percent !== undefined || sla.elapsedHours !== undefined); + const hasValidSLA = sla && (sla.percentageUsed !== undefined || sla.elapsedHours !== undefined); if (!hasValidSLA || requestStatus === 'approved' || requestStatus === 'rejected' || requestStatus === 'closed') { return ( @@ -51,8 +51,7 @@ export function SLAProgressBar({ // Use percentage-based colors to match approver SLA tracker // Green: 0-50%, Amber: 50-75%, Orange: 75-100%, Red: 100%+ (breached) // Grey: When paused (frozen state) - // Handle both full format (percentageUsed) and simplified format (percent) - const percentageUsed = sla.percentageUsed !== undefined ? sla.percentageUsed : (sla.percent || 0); + const percentageUsed = sla.percentageUsed !== undefined ? sla.percentageUsed : 0; const rawStatus = sla.status || 'on_track'; // Determine colors based on percentage (matching ApprovalStepCard logic) diff --git a/src/dealer-claim/components/request-detail/WorkflowTab.tsx b/src/dealer-claim/components/request-detail/WorkflowTab.tsx index eef998a..c08a6a0 100644 --- a/src/dealer-claim/components/request-detail/WorkflowTab.tsx +++ b/src/dealer-claim/components/request-detail/WorkflowTab.tsx @@ -343,8 +343,6 @@ export function DealerClaimWorkflowTab({ // Waiting steps (future steps) should have elapsedHours = 0 // This ensures that when in step 1, only step 1 shows elapsed time, others show 0 const isWaiting = normalizedStatus === 'waiting'; - const isActive = normalizedStatus === 'pending' || normalizedStatus === 'in_progress'; - const isCompleted = normalizedStatus === 'approved' || normalizedStatus === 'rejected'; // Only calculate/show elapsed hours for active or completed steps // For waiting steps, elapsedHours should be 0 (they haven't started yet) diff --git a/src/dealer-claim/components/request-detail/modals/CreditNoteSAPModal.tsx b/src/dealer-claim/components/request-detail/modals/CreditNoteSAPModal.tsx index aace86c..dc3c9cc 100644 --- a/src/dealer-claim/components/request-detail/modals/CreditNoteSAPModal.tsx +++ b/src/dealer-claim/components/request-detail/modals/CreditNoteSAPModal.tsx @@ -139,7 +139,7 @@ export function CreditNoteSAPModal({ - {status === 'APPROVED' || status === 'CONFIRMED' ? 'Approved' : status === 'ISSUED' ? 'Issued' : status === 'SENT' ? 'Sent' : 'Pending'} + {status === 'APPROVED' ? 'Approved' : status === 'ISSUED' ? 'Issued' : status === 'SENT' ? 'Sent' : 'Pending'}