laxmanhalaki/Dealer_Onboarding_Backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6277a2dbc3
Dealer_Onboarding_Backend/docs/Backend_Alignment_Report_v1.4.md

4.9 KiB
Raw Blame History

Backend Alignment Analysis Report (v1.4 Compliance)

Based on the review of Comparison_Summary_v1.0_vs_v1.4.md, Re_New_Dealer_Onboard_TWO.md, and dealer_onboard_backend_schema.mermaid, here is the analysis of the current backend implementation status and alignment gaps.

1. Executive Summary

The current backend implementation is in an early stage (Foundation) and lacks the majority of the complex workflows and governance features required by Version 1.4 of the documentation. While basic models for Applications, Resignations, and Self-Service (Constitutional/Relocation) exist, the business logic, approval hierarchies, and supporting modules are missing.

2. Critical Gaps & Missing Modules

2.1 Missing Business Modules

  • Termination Module (CRITICAL): Completely missing from the codebase. There are no models, routes, or controllers for handling dealer termination.
  • Dealer Code Manual Trigger: Current documentation (1.1.3) requires DD Admin to manually trigger code generation in SAP. The code lacks this control point.
  • LOI & LOA Sub-Workflows: Documentation (6.16, 6.18) describes complex approval and document issuance processes for Letters of Intent and Letters of Appointment. These are currently simplified or non-existent in the code.
  • Questionnaire & Scoring (KT Matrix): Module for automated questionnaire scoring, rankings, and KT Matrix interview evaluation is missing.
  • EOR Checklist: Detailed Essential Operating Requirements (EOR) checklist with functional team verifications is not implemented.
  • Inauguration Tracking: Final stage of onboarding is missing.

2.2 Governance & Roles (RBAC)

  • CEO/CCO Roles: Missing from config/constants.js and User.js. Version 1.4 requires CEO approval for Termination.
  • Super Admin Segregation: The planned split of Super Admin into two specialized DD Admin roles is not reflected in the current role structure.
  • Send Back / Revoke Authority: The resignationController.js only implements basic approve/reject. It lacks the "Send Back" logic requested for ZBH, DD Lead, DD Head, and NBH.

2.3 Self-Service Logic

  • Resignation Withdrawal: Documentation allows withdrawal "only until NBH review". This restriction is not enforced in the current controller.
  • LWD-Based F&F Trigger: F&F settlement must be triggered "strictly on the Last Working Day (LWD)". The current FnF.js and resignationController.js do not enforce this temporal bridge.
  • WhatsApp Integration: Requirement 1.1.1 (Multi-channel alerts) is missing implementation in the notifications layer.

3. Schema Alignment Check

The dealer_onboard_backend_schema.mermaid provides a high-fidelity design. The physical database (models/) is missing approximately 70% of the tables defined in the schema.

Missing Tables in Code:

Document Section Missing Tables (Models)
Questionnaire QUESTIONNAIRES, SECTIONS, QUESTIONS, RESPONSES, SCORES
Interviews INTERVIEWS, PARTICIPANTS, EVALUATIONS, KT_MATRIX_SCORES, FEEDBACK
LOI Process LOI_REQUESTS, LOI_APPROVALS, LOI_DOCUMENTS_GENERATED, ACKNOWLEDGEMENTS
EOR / Construction ARCHITECTURAL_ASSIGNMENTS, EOR_CHECKLISTS, CHECKLIST_ITEMS, CONSTRUCTION_PROGRESS
Termination TERMINATION_REQUESTS, TERMINATION_APPROVALS, SCN_ISSUANCE
Other AI_SUMMARIES, INAUGURATIONS, SECURITY_DEPOSITS

4. Required Backend Changes to Align with Documentation

Phase 1: Governance & Framework (Immediate)

  1. Update constants.js: Add CEO, CCO roles and TERMINATION_STAGES.
  2. Enhance Workflow Engine: Implement a generic "Send Back" mechanism that tracks the previous stage and logs mandatory audit remarks.
  3. Audit Trail Expansion: Ensure every state change captures the "Section 4.4" requirements (Uploader, Timestamp, Versioning).

Phase 2: Workflow Refinement

  1. Sequence Correction (LOA before EOR): Restructure the Application state machine to ensure LOA issuance is a prerequisite for EOR checklist activation.
  2. LWD Enforcement: Modify FnF initiation logic to check against outlet.last_working_day.
  3. Manual Code Trigger: Add dedicated endpoint /api/applications/:id/generate-code restricted to DD_ADMIN.

Phase 3: Module Completion

  1. Develop Termination Controller: Implement the 11-step process described in Section 4.3.
  2. Questionnaire Engine: Move from hardcoded fields to a dynamic questionnaire system as per the schema.
  3. Document Repository: Implement the "Central Document Repository" with versioning for Statutory and Architectural documents.

Status Recommendation: The backend requires significant structural updates to meet the "Version 1.4" standards described in the documentation. High priority should be given to Role updates and the Termination module.